Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentry-native: add option to switch crashpad dependency #5717

Merged
merged 3 commits into from
Jun 2, 2021
Merged

sentry-native: add option to switch crashpad dependency #5717

merged 3 commits into from
Jun 2, 2021

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Jun 1, 2021

Specify library name and version: sentry-native/all

Add option to swtich crashpad dependency between official upstream google crashpad and sentry's crashpad fork.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Jun 1, 2021
Open
@madebr madebr mentioned this pull request Jun 1, 2021
Merged
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 2 (d48390bfb6e6078b9782958abc9542589f011f34):

  • sentry-native/0.4.8@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.9@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.1@:
    All packages built successfully! (All logs)

  • sentry-native/0.4.7@:
    All packages built successfully! (All logs)

  • sentry-native/0.2.6@:
    All packages built successfully! (All logs)

@SSE4
Copy link
Contributor

SSE4 commented Jun 2, 2021

@prince-chrismc can you explain for me the relationship between these sentry-projects? (e.g. sentry, sentry-native, sentry-crashpad, sentry-breakpad, crashpad, breakpad, etc.)

@prince-chrismc
Copy link
Contributor

Oh I am no expert! I'll do my best... There's a bunch of of OSS libraries for "stack trace error handling" (eg crashpad/breakpad)

The Sentry community (I like to romanticize it's because Conan did not exist) forked the projects to their build tree and added them as dependencies... over time they made minor changes so there's a slight difference between the original and the sentry- prefixed ones....

As a OSS purist you might be using the original crashpad for you application and do not want to mix the possibly different ABIs... so you replace the sentry version with the one you like

@SSE4 SSE4 requested a review from uilianries June 2, 2021 14:12
@conan-center-bot conan-center-bot merged commit b03c242 into conan-io:master Jun 2, 2021
@madebr
Copy link
Contributor Author

madebr commented Jun 2, 2021

@prince-chrismc
I couldn't explain it better myself!
Thanks!

@madebr madebr deleted the sentry_native_crashpad branch June 2, 2021 20:40
@madebr madebr mentioned this pull request Jun 2, 2021
Merged
4 tasks
madebr added a commit to madebr/conan-center-index that referenced this pull request Jun 21, 2021
@madebr
(conan-io#5717) sentry-native: add option to switch crashpad dependency
4de1ba9 
* sentry-native: add option to switch crashpad dependency

* sentry-native: fix compatibility with sentry-crashpad

* sentry-native: add missing patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@ericriff ericriff ericriff approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madebr @conan-center-bot @SSE4 @prince-chrismc @ericriff